Dev response to tradeskill return failures
Posted: Tue Apr 07, 2020 9:26 pm
https://forums.daybreakgames.com/eq/ind ... st-3888412
This was a mixed data error and code weirdness that was a "bug like feature." When it ran through fails it would check the first fail data field, if -1, it would stop. It didn't check the other 3 data fields. The return crystallized precious velium ore was in the second data field :/ So the LOSS rate WAS higher than I intended.
On the other hand, the salvage code would check the whole array of four possible fail returns, so would see the ore as something that would be returned, and not process that item as salvage (this is to keep from duplicating items with salvage), but then NORMAL return (from what I said above) would not happen because of the code and data oddity.
In the end, a fix for the data AND a change in the way salvage works is coming in this patch. AND code made that part of the code less weird, and checks all four fail fields so malformed but essentially valid data won't break combines.
https://forums.daybreakgames.com/eq/ind ... st-3888573
IT was meant to return on a normal fail (Draught or not) and NOT return on the RARE alt-fail. (Draught or not)
Change: It will return on a normal fail (Draught or not) and NOT return on the Rare alt-Fail. If you are using a Draught, Alt fail will not roll at all, so you can only get a Normal fail (ore returned)
This was a mixed data error and code weirdness that was a "bug like feature." When it ran through fails it would check the first fail data field, if -1, it would stop. It didn't check the other 3 data fields. The return crystallized precious velium ore was in the second data field :/ So the LOSS rate WAS higher than I intended.
On the other hand, the salvage code would check the whole array of four possible fail returns, so would see the ore as something that would be returned, and not process that item as salvage (this is to keep from duplicating items with salvage), but then NORMAL return (from what I said above) would not happen because of the code and data oddity.
In the end, a fix for the data AND a change in the way salvage works is coming in this patch. AND code made that part of the code less weird, and checks all four fail fields so malformed but essentially valid data won't break combines.
https://forums.daybreakgames.com/eq/ind ... st-3888573
IT was meant to return on a normal fail (Draught or not) and NOT return on the RARE alt-fail. (Draught or not)
Change: It will return on a normal fail (Draught or not) and NOT return on the Rare alt-Fail. If you are using a Draught, Alt fail will not roll at all, so you can only get a Normal fail (ore returned)